Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): add babel config types #5666

Merged
merged 3 commits into from
May 7, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 7, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from kevinmarrec May 7, 2019 09:34
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarkdo ! Just a little change and it's good :)

packages/config/types/build.d.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #5666 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5666   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          81       81           
  Lines        2635     2635           
  Branches      671      671           
=======================================
  Hits         2521     2521           
  Misses         96       96           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a05145...e412c61. Read the comment docs.

@clarkdo clarkdo requested a review from kevinmarrec May 7, 2019 09:45
@atinux atinux self-requested a review May 7, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants