fix(server): preserve random port when restarting #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Can we move used port variable to the listener.js file? Memorizing random port and reusing it again. |
|
Will do it :) |
Codecov Report
@@ Coverage Diff @@
## dev #5793 +/- ##
==========================================
+ Coverage 95.66% 95.67% +<.01%
==========================================
Files 82 82
Lines 2675 2679 +4
Branches 685 685
==========================================
+ Hits 2559 2563 +4
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
pi0
changed the title
|
Thanks @pi0 for the refactor and tests ❤️ I reviewed and approve (but cannot through GH since I am the author of the PR). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
It's only for
nuxt devcommand.When the given port is already used and Nuxt uses a random port, changing
nuxt.config.jswill restart the server but it will assign another port again and the DX is ruined.This PR aims to re-uses the same port when a random port is assigned at first.
Checklist:
-> Will need some help here @clarkdo 🙏