Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve browser logs #5810

Merged
merged 2 commits into from
May 27, 2019
Merged

feat: improve browser logs #5810

merged 2 commits into from
May 27, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 26, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Aligning DX with consola 2.7.0:

  • Omit nuxt:ssr tag as we already grouped logs with "Nuxt SSR Logs"

image

  • Wrap console in dev mode for fancier global logs

image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from atinux, clarkdo and a team May 26, 2019 10:24
@pi0 pi0 changed the title Feat/improve browser log feat: improve browser logs May 26, 2019
@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #5810 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5810   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2688     2688           
  Branches      689      689           
=======================================
  Hits         2572     2572           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.37% <ø> (ø) ⬆️
#unit 92.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f74362...7be2f78. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants