-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-app): add <client-only> alias for <no-ssr> #5941
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5941 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 82 82
Lines 2693 2693
Branches 692 692
=======================================
Hits 2577 2577
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
Actually I thought about the same 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍
Does this mean that we are going to deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding alias
in NoSsr
and use Vue.component(NoSsr.alias, NoSsr)
here
I believe this is a solution to a problem that doesnt exists and therefore adds too much (useless) configuration. Although there might be reasons for changing this I am unaware of? @manniL posted a nice link what mentions this yesterday on discord |
@pimlie I'd say the reason is just about DX. |
Configurable alias makes integration harder and fragments users. Like a module that adds components that rely on |
If replacing |
i think should keep i didn't use why use |
This could already be done in userland. If we adopt a new name, we should enforce it as well and deprecate |
+1 on introducing alias-only. |
Indeed VuePress has a Actually, for DX, I would suggest to rename to and set up an alias for
|
To make this PR valid, I recommend to:
|
I did the changes required + added a PR on the docs. |
I'll do it. |
@clarkdo already did: nuxt/docs#1472 |
@atinux PR for Chinese nuxt/docs#1473 |
Types of changes
Description
Checklist: