refactor(core): use hable

[pi0]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

jsless/hable is an extraction of our internal hooks implementation with the same tests and features. Pros of externalizing:

• Easier maintenance
• Using a consistent solution across different areas (I'm making a PR for using hooks in cli for example)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[pimlie]

Hable & Hookable dont have a fully similar interface and implementation

[pi0]

@pimlie hmm I'm not sure. Can you please elaborate more about differences and potentially missing requirements?

UPDATE: Hable 2.1.0 supports custom logger (consola) and optional fatal for nuxt behaviour compatibility.

[atinux]

YES!

[codecov-io]

Codecov Report

Merging #6271 into dev will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #6271      +/-   ##
==========================================
- Coverage   95.76%   95.67%   -0.09%     
==========================================
  Files          80       79       -1     
  Lines        2666     2636      -30     
  Branches      687      679       -8     
==========================================
- Hits         2553     2522      -31     
- Misses         97       98       +1     
  Partials       16       16

Flag	Coverage Δ
#e2e	100% <ø> (ø)	⬆️
#fixtures	50.26% <100%> (-0.38%)	⬇️
#unit	92.33% <100%> (-0.13%)	⬇️

Impacted Files	Coverage Δ
packages/core/src/nuxt.js	94.73% <100%> (ø)	⬆️
packages/vue-renderer/src/renderer.js	93.49% <0%> (-0.82%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac5544...6511eef. Read the comment docs.

[clarkdo]

LGTM

[pimlie]

Hookable:

• flatHooks as instance method (probable safe to remove though, but who knows)
• filter(Boolean) in addHooks

Hable:

• deprecateHook

When moving to Hable, Nuxt should use the deprecateHook method instead of setting the prop directly.

Hable will add falsy hooks in addHooks / flatHooks util. Actually it will also add all other non-function hooks, but thats also the case with Hookable.

[pi0]

flatHooks as an instance method (probable safe to remove though, but who knows)

This is an internal utility. So I think it is safe to not include in instance.

deprecateHook

Yeah. That's an addition of hable that we can leverage :) I'll refactor to use it.

UPDATE: hable 2.2.1 has deprecateHooks util.

filter(Boolean) in addHooks

Main hook function which is called by addHooks already prevents adding falsy hooks.

answered