Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): enable total timing by default when server.timing is enabled #6371

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 5, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4800 (comment)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team September 5, 2019 18:53
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #6371 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6371      +/-   ##
==========================================
+ Coverage   95.74%   95.75%   +<.01%     
==========================================
  Files          79       79              
  Lines        2681     2684       +3     
  Branches      692      693       +1     
==========================================
+ Hits         2567     2570       +3     
  Misses         98       98              
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.89% <100%> (+0.05%) ⬆️
#unit 92.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/config/src/options.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376b2b0...219081e. Read the comment docs.

@pi0 pi0 changed the title fix: enable total time by default when server-timing is enabled fix(config): enable total timing by default when server.timing is enabled Sep 9, 2019
@pi0 pi0 merged commit 8ccca22 into dev Sep 9, 2019
@pi0 pi0 deleted the timing-total branch September 9, 2019 14:44
@pi0 pi0 mentioned this pull request Sep 26, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants