Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collapsed ssr log #6590

Merged
merged 1 commit into from
Oct 18, 2019
Merged

fix: collapsed ssr log #6590

merged 1 commit into from
Oct 18, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Oct 18, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Collapsed ssr logs are currently broken to a space between group & Collapsed

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pimlie pimlie requested a review from clarkdo October 18, 2019 09:26
@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #6590 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6590   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          78       78           
  Lines        2705     2705           
  Branches      699      699           
=======================================
  Hits         2593     2593           
  Misses         97       97           
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.73% <ø> (ø) ⬆️
#unit 92.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6589c...2e604de. Read the comment docs.

@clarkdo clarkdo merged commit b031fac into nuxt:dev Oct 18, 2019
@pi0
Copy link
Member

pi0 commented Oct 18, 2019

We lack a test for it ;)

@clarkdo
Copy link
Member

clarkdo commented Oct 18, 2019

I’ll add a test

@pimlie pimlie deleted the fix-group-collapse branch October 18, 2019 09:44
@pi0 pi0 mentioned this pull request Oct 21, 2019
@pi0 pi0 mentioned this pull request Dec 17, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants