Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): avoid multiple $fetch calls #7129

Merged
merged 4 commits into from
Mar 25, 2020
Merged

fix(vue-app): avoid multiple $fetch calls #7129

merged 4 commits into from
Mar 25, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 25, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Co-authored-by: Aster duda84@gmail.com

fixes #7107. closes #7108.

  • Ensure lifecycle hooks registering once
  • Ensure only one fetch promise is active per component instance

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #7129 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7129   +/-   ##
=======================================
  Coverage   62.69%   62.69%           
=======================================
  Files          84       84           
  Lines        3394     3394           
  Branches      926      926           
=======================================
  Hits         2128     2128           
  Misses       1018     1018           
  Partials      248      248           
Flag Coverage Δ
#unittests 62.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82f8d1...0876311. Read the comment docs.

@pi0 pi0 added WIP and removed WIP labels Mar 25, 2020
@atinux atinux self-requested a review March 25, 2020 18:40
@tarunmangukiya
Copy link

I am seeing this issue even after updating #7191

@pi0
Copy link
Member Author

pi0 commented Apr 10, 2020

@tarunmangukiya As per #7191 (comment) do you still have this issue?

@tarunmangukiya
Copy link

The issue has been resolved. That was Cloudflare Proxy issue.
I'll deploy it to live in a day or two. And we'll be able to see new fetch APIs in action. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new fetch() api called multiple times
5 participants