-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic counter examples #453
Conversation
Hmm my demo app is not coming through in the code sandbox embeds in the netlify preview page... why? 🤔 https://deploy-preview-453--nuxt-typescript.netlify.app/examples/options-api/basic.html Can any repo maintainers point me in the right direction? EDIT: Oh it's becasue, CSB is look for the code in the master branch of the repo, so it will work once it's merged in? Would be nice to see it working in a netlify deploy preview somehow... perhaps I'm missing something? |
Hi @chiubaca , thanks for your PR, would you mind switching from |
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 32 32
Branches 8 8
=========================================
Hits 32 32 Continue to review full report at Codecov.
|
@kevinmarrec no probs, was for my own learning 😄. I've purged the |
@chiubaca Oh yeah sorry ! That's intended :) Gonna perform a new review now |
Vue.use(VueCompositionApi) | ||
|
||
export default defineComponent({ | ||
name: 'CompositionAPICounter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ln 17? Vue.use(VueCompositionApi)
thats been removed in one of the other commits now.
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
@kevinmarrec Noticed the nuxt docs have had revamp since this PR. There used to be these additional sections in the examples: Hope you can still carve a home for these examples somewhere 🙏. I was also interested in helping produce some "Advance" examples too. Just let me know if I can help in any way. |
@chiubaca Yes, i'm waiting tests to be resolved with my last commit (unused import) then I'm gonna merge. Finally I'll take time to see how these basic examples can show up again on new documentation :) |
This is PR provides a simple counter demo implemented with Options API, Class API and Composition API for each of the "Basic" examples at https://typescript.nuxtjs.org/examples/options-api/basic.html