Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic counter examples #453

Merged
merged 15 commits into from
Feb 22, 2021
Merged

Basic counter examples #453

merged 15 commits into from
Feb 22, 2021

Conversation

chiubaca
Copy link
Contributor

@chiubaca chiubaca commented Oct 11, 2020

This is PR provides a simple counter demo implemented with Options API, Class API and Composition API for each of the "Basic" examples at https://typescript.nuxtjs.org/examples/options-api/basic.html

@chiubaca chiubaca changed the title Examples Basic counter examples Oct 12, 2020
@chiubaca
Copy link
Contributor Author

chiubaca commented Oct 12, 2020

Hmm my demo app is not coming through in the code sandbox embeds in the netlify preview page... why? 🤔

https://deploy-preview-453--nuxt-typescript.netlify.app/examples/options-api/basic.html

Can any repo maintainers point me in the right direction?

EDIT: Oh it's becasue, CSB is look for the code in the master branch of the repo, so it will work once it's merged in? Would be nice to see it working in a netlify deploy preview somehow... perhaps I'm missing something?

@chiubaca chiubaca marked this pull request as ready for review October 12, 2020 19:44
@kevinmarrec kevinmarrec added the documentation The issue or pull request related to the documentation label Feb 21, 2021
@kevinmarrec
Copy link
Contributor

Hi @chiubaca , thanks for your PR, would you mind switching from npm to yarn for the examples ? (yarn.lock instead of package-lock.json)

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #453 (daf1897) into master (9c35835) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           32        32           
  Branches         8         8           
=========================================
  Hits            32        32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7f852...daf1897. Read the comment docs.

@chiubaca
Copy link
Contributor Author

@kevinmarrec no probs, was for my own learning 😄.

I've purged the package-lock.json files. I generated the yarn.lock files on my local machine but noticed there's a .gitignore rule at line 5 preventing them from being committed though...

@kevinmarrec
Copy link
Contributor

@chiubaca Oh yeah sorry ! That's intended :)

Gonna perform a new review now

Vue.use(VueCompositionApi)

export default defineComponent({
name: 'CompositionAPICounter',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ln 17? Vue.use(VueCompositionApi) thats been removed in one of the other commits now.

chiubaca and others added 6 commits February 22, 2021 11:04
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
chiubaca and others added 2 commits February 22, 2021 11:40
Co-authored-by: Kevin Marrec <kevin@marrec.io>
Co-authored-by: Kevin Marrec <kevin@marrec.io>
@chiubaca
Copy link
Contributor Author

@kevinmarrec Noticed the nuxt docs have had revamp since this PR. There used to be these additional sections in the examples:

image

Hope you can still carve a home for these examples somewhere 🙏. I was also interested in helping produce some "Advance" examples too. Just let me know if I can help in any way.

@kevinmarrec
Copy link
Contributor

@chiubaca Yes, i'm waiting tests to be resolved with my last commit (unused import) then I'm gonna merge.

Finally I'll take time to see how these basic examples can show up again on new documentation :)

This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue or pull request related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants