Skip to content

Outdated typescript dependency #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rchl opened this issue Sep 4, 2022 · 6 comments · Fixed by #563
Closed

Outdated typescript dependency #557

rchl opened this issue Sep 4, 2022 · 6 comments · Fixed by #563

Comments

@rchl
Copy link
Collaborator

rchl commented Sep 4, 2022

Describe the bug
This package has typescript dependency pinned to ~4.2 which causes issues in projects that require new version of typescript. Installing later version of typescript in the project causes various weird errors due to two versions of typescript being present in the project. What's the reason for pinning old version?

To Reproduce
The issue can be reproduced on the https://github.com/rchl/lsp-log-parser/ project after removing resolutions from package.json.

Expected behavior
No errors after installing new version of typescript in the project
or
don't pin old version of typescript in dependencies

Additional context
This issue can be worked around by using yarn resolutions.

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Sep 4, 2022

Pinned minor version was due to various type errors encountered cause of some Vue types with oldest Typescript versions, but I guess it's pretty safe to bump it to latest.

I didn't plan any updates soon so I'd stick with resolutions as it's straight forwards workaround.

I may update it later on.

@rchl
Copy link
Collaborator Author

rchl commented Sep 4, 2022

resolutions is a workaround and also not even currently documented so that means that people will either not figure it out themselves or have to spend a good amount of time figuring it out.

Also, not sure what would be the workaround with npm since it doesn't support resolutions.

@homerjam
Copy link

@rchl Could you please show how you worked around the issue with resolutions? I'm having trouble!

@rchl
Copy link
Collaborator Author

rchl commented Nov 26, 2022

@rchl
Copy link
Collaborator Author

rchl commented Mar 8, 2023

@kevinmarrec why are you insisting on keeping old version pinned? Having such an old version in the project causes type issues.

@rchl
Copy link
Collaborator Author

rchl commented Mar 8, 2023

If you are afraid of breaking existing setups then you can create a new major release.

If you are still not planning to update it then I'll probably have to create a fork and publish as a separate packge.

(And please don't suggest using bridge instead since it's a can of worms in Nuxt 2)

@pi0 and @danielroe for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants