fix(typescript-build): set logger instance correctly #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing whole Consola instance to
fork-ts-checker-webpack-plugin
options, which can't be serialized and would crash when trying to use JSON.serialize on it (see how it can happen in the linked issue), pass only an interface with required methods.Our custom
consola
was not used AT ALL before this change. It was not set in the correct place sofork-ts-checker-webpack-plugin
ignored it completely and just logged errors usingconsole
API. So this is also fixed now, in addition to fixing the crash.Fixes #504