fix: extend typescript peer dependency range to include 5.x #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 36 36
Branches 9 9
=========================================
Hits 36 36 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
danielroe
approved these changes
Mar 26, 2023
|
@danielroe when you have spare time I think it would be good to release a new version now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After quick look there doesn't seem to be any apparent issues with TypeScript 5 so allow it in the peer dependency range.
Given that TypeScript doesn't really follow semantic versioning rules, it can break at any point but I still think that this is better approach then having to update this module on each TypeScript release. If new TS version breaks this module then we can restrict or fix it then.