fix(Form): resolve async validation in yup & issue directly mutate state #2701
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjanuar
commented
Nov 20, 2024
| @@ -87,7 +89,7 @@ export default defineComponent({ | |||
| if (errors) { | |||
| errs = errs.concat(errors) | |||
| } else { | |||
| Object.assign(props.state, result) | |||
There was a problem hiding this comment.
@romhml I think we shouldn't mutate the state data directly because when we use transformation methods like .transform((v) => v.toUpperCase()), it automatically changes the input value displayed to the user. Instead, the transform method should only modify the return value while preserving the original state
8 tasks
Deploying ui3 with
|
| Latest commit: |
c06b4db
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #2691
❓ Type of change
📚 Description
📝 Checklist