Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts): add microdata meta tag type #382

Merged
merged 2 commits into from
Jun 7, 2019
Merged

feat(ts): add microdata meta tag type #382

merged 2 commits into from
Jun 7, 2019

Conversation

georgeboot
Copy link
Contributor

This PR adds support for schema.org meta tags, like the following ones:

<html>

...

<meta itemprop="@type" content="Event">
<meta itemprop="datePublished" content="2019-06-07">

...

</html>

@codecov-io
Copy link

codecov-io commented Jun 7, 2019 •
edited
Loading

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          30       30           
  Lines         409      409           
  Branches      115      115           
=======================================
  Hits          405      405           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4980c...1355744. Read the comment docs.

@pimlie
Copy link
Collaborator

pimlie commented Jun 7, 2019

Thanks for the PR!

Would the name MetaPropertyMicrodata maybe be more applicable? Eg doesnt schema.org provide metadata schemes using the Microdata specification?

@georgeboot
Copy link
Contributor Author

Considered that, bit micro data is generally injected on html items themselves, right? Since this only affects the meta tags, I kind of thought this would be a better name.

But can live with both.

@pimlie
Copy link
Collaborator

pimlie commented Jun 7, 2019

Then I would prefer Microdata, mostly because you could also put a Schema.org definition as ld+json in a script tag and in this case you need to be able to define microdata in the meta-tags which in general might not be limited to just schema.org definitions.

@georgeboot
Copy link
Contributor Author

Updated

@pimlie pimlie changed the title Adding schema.org meta tag type feat(ts): add microdata meta tag type Jun 7, 2019
@pimlie pimlie merged commit 11c8138 into nuxt:master Jun 7, 2019
@pimlie
Copy link
Collaborator

pimlie commented Jun 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgeboot @codecov-io @pimlie