Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't generate <title> tag if metaInfo.title is falsy #409

Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix: don't generate <title> tag if metaInfo.title is falsy #409

merged 1 commit into from
Jul 16, 2019

Conversation

lmichelin
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #409 into master will decrease coverage by 0.23%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage     100%   99.76%   -0.24%     
==========================================
  Files          30       30              
  Lines         423      427       +4     
  Branches      120      122       +2     
==========================================
+ Hits          423      426       +3     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/shared/escaping.js 100% <100%> (ø) ⬆️
src/server/generators/title.js 75% <50%> (-25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c35863...fca7e1b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #409 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #409   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     30           
  Lines         423    426    +3     
  Branches      120    122    +2     
=====================================
+ Hits          423    426    +3
Impacted Files Coverage Δ
src/shared/escaping.js 100% <100%> (ø) ⬆️
src/utils/is-type.js 100% <100%> (ø) ⬆️
src/server/generators/title.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b150d82...3002cc2. Read the comment docs.

@lmichelin lmichelin changed the title fix: don't generate <title> tag if metaInfo.title is null fix: don't generate <title> tag if metaInfo.title is null or false Jul 13, 2019
Copy link
Collaborator

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr, I have some small remarks/requests.

Also please merge the master branch to exclude the dist folder again. If those files wont be removed after merging the master branch use git reset dist/* and if thats not enough git checkout HEAD -- dist/* to reset your branch back to the master state. Sorry for that

src/server/generators/title.js Outdated Show resolved Hide resolved
src/shared/escaping.js Outdated Show resolved Hide resolved
@lmichelin
Copy link
Contributor Author

Thanks for this pr, I have some small remarks/requests.

Also please merge the master branch to exclude the dist folder again. If those files wont be removed after merging the master branch use git reset dist/* and if thats not enough git checkout HEAD -- dist/* to reset your branch back to the master state. Sorry for that

Just removed the changes in the dist folder 😉

Copy link
Collaborator

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work!

@pimlie pimlie changed the title fix: don't generate <title> tag if metaInfo.title is null or false fix: don't generate <title> tag if metaInfo.title is falsy Jul 15, 2019
@pimlie pimlie merged commit 39ef287 into nuxt:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metatag title save in builded index.html even with config.head.title = false (or null)
2 participants