-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't generate <title> tag if metaInfo.title is falsy #409
Conversation
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 100% 99.76% -0.24%
==========================================
Files 30 30
Lines 423 427 +4
Branches 120 122 +2
==========================================
+ Hits 423 426 +3
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 30 30
Lines 423 426 +3
Branches 120 122 +2
=====================================
+ Hits 423 426 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pr, I have some small remarks/requests.
Also please merge the master branch to exclude the dist folder again. If those files wont be removed after merging the master branch use git reset dist/*
and if thats not enough git checkout HEAD -- dist/*
to reset your branch back to the master state. Sorry for that
Just removed the changes in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick work!
Fixes nuxt/nuxt#6063