-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option for prepending (no)script to body #410
Conversation
Nice PR @pimlie I don't know what to feel about |
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 100% 99.55% -0.45%
==========================================
Files 30 31 +1
Lines 430 449 +19
Branches 125 127 +2
==========================================
+ Hits 430 447 +17
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 100% 99.55% -0.45%
==========================================
Files 30 31 +1
Lines 430 449 +19
Branches 125 127 +2
==========================================
+ Hits 430 447 +17
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Renamed |
Good for me (expect failing test 😄 ) |
Ha, thanks for the heads-up. Getting a bit too used to failing tests due to the IE issue I guess ;) |
thanks for you work @pimlie (cc @atinux). Wouldn‘t it be nicer to extend the existing |
@derz Thank you for your comment. I can see the logic in your suggestion. After this PR was merged I realized it would maybe also be nice to just add extra methods, so instead of calling But I am not strongly opinionated on the matter, so I will leave the initiative to change this API to someone else :) |
Resolves: #370
I couldnt came up with a good single name, so I decided on
pody
as in prepended body.I am happy to change this to something better, but I'd prefer to keep it to a single word so we dont have kebab/camelCase issues when switching between js object property and html attribute name.