fix: also set ssrAppId for first Vue app when ssrAttribute exists #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute exists"" This reverts commit 3057828.
pimlie
commented
May 16, 2020
| // do see our own ssrAttribute then _assume_ the Vue app with appId 1 is the ssr app | ||
| // attempted fix for #404 & #562, but we rly need to refactor how we pass appIds from | ||
| // ssr to the client | ||
| if (!wasServerRendered && $root[rootConfigKey] && $root[rootConfigKey].appId === 1) { |
There was a problem hiding this comment.
This if is the possible hacky part
There was a problem hiding this comment.
this.$el.hasAttribute('data-server-rendered') will work only for Vue 2 anyway
|
I can't say much about the correctness of the detection of But I can confirm that this fixes #562 (Nuxt SSR). |
superbchris
approved these changes
May 25, 2020
abid-superbalist
approved these changes
May 25, 2020
atinux
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #404 and resolve #562
@kevinmarrec Would this fix be an issue with Vuetify? I know previously we had issues with that because they start new Vueapp's for modals etc. But I would guess that if you use Vuetify with SSR the Vue app that uses Vuetify will be initiated first?
I feel this fix is a bit hacky, but I dont think there is a proper way that vue-meta can currently pass the appId from ssr to the client without introducing a breaking change. This fix should handle like 99+% of the normal use-cases (if Vuetify plays along).
(The reverts are just because I first pushed on master, but then decided it was better to do a PR first)