Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When add-on publication date is added, the json file is not valid #39

Open
nvdaes opened this issue Sep 18, 2024 · 5 comments
Open

When add-on publication date is added, the json file is not valid #39

nvdaes opened this issue Sep 18, 2024 · 5 comments

Comments

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented Sep 18, 2024

Steps to reproduce

  • Install the last version ofWindows App Essential submitted today by @josephsl in latest alpha of NVDA.
  • Open the add-on store and browse add-ons
  • See the log when Windows App Essential is selected.
  • In your local computer, edit the json file adding a submission time manually
  • Run again NVDA and open the store,to see that the error is fixed.

I think that somekindof encoding error is produced when creating the json file.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Sep 18, 2024

Sorry, the issue seems to be in NVDA implementation: submissionTime has to be divided by 1000 in NVDA. I'lltest this locally with the wintenApps.json fileincluded in the store, and ifthis works I'll create a PR to fixup this.I think that creating a new issue in NVDA is not needed for this obvious error.
I'll mention this issue.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Sep 18, 2024

Though another approach is to make the division in this repo.
I'llwait for @seanbudd thoughts.
If this repo is changed, wintenApps latest version should be replaced.

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Sep 18, 2024

In fact, testing with NVDA dividing the submission time of Windows App Essential with // 1000, the issue is fixed. In this repo, we are multiplying the timestamp with * 1000. We may try to remove this and submit some add-on for testing.

@seanbudd
Copy link
Member

At this stage, the code is in the submission process. I would encourage making the fix in NVDA as appropriate

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Sep 19, 2024

I've created nvaccess/nvda#17193 PR. I'll mark this as ready for review since all checks pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants