Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import SVG as a component (ReactComponent) #180

Closed
nvh95 opened this issue Jul 3, 2022 · 0 comments · Fixed by #195
Closed

Support import SVG as a component (ReactComponent) #180

nvh95 opened this issue Jul 3, 2022 · 0 comments · Fixed by #195
Assignees
@nvh95
Labels
feature request Request a new feature

Comments

@nvh95
Copy link
Owner

nvh95 commented Jul 3, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Now, the fileCRA transformer just copied the implementation of mocking .svg file. So SVG file is not displayed in the preview

Describe the solution you'd like

Describe how should jest-preview implements this feature

  • svgr has Node API for us to convert an SVG file to a React component
@nvh95 nvh95 added the feature request Request a new feature label Jul 3, 2022
@nvh95 nvh95 changed the title Support import SVG as a component Support import SVG as a component (ReactComponent) Jul 3, 2022
@nvh95 nvh95 assigned nvh95 and unassigned ntt261298 Jul 10, 2022
@ntt261298 ntt261298 mentioned this issue Jul 10, 2022
Merged
2 tasks
@nvh95 nvh95 linked a pull request Jul 15, 2022 that will close this issue
feat: Support viewing SVG if import as ReactComponent #195
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvh95 nvh95

Labels
feature request Request a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support viewing SVG if import as ReactComponent nvh95/jest-preview
2 participants
@nvh95 @ntt261298