Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlenaryBustedDirectory not working on windows #255

Open
qgymib opened this issue Oct 12, 2021 · 2 comments
Open

PlenaryBustedDirectory not working on windows #255

qgymib opened this issue Oct 12, 2021 · 2 comments

Comments

@qgymib
Copy link

qgymib commented Oct 12, 2021

This is beacuse currently plenary.test_harness use find to get all *_spec.lua, but windows builtin FIND is quite different from gnu find, which leads harness._find_files_to_run return an empty result.

function harness._find_files_to_run(directory)
  local finder = Job:new {
    command = "find",
    args = { directory, "-type", "f", "-name", "*_spec.lua" },
  }

  return vim.tbl_map(Path.new, finder:sync())
end

May be it is better to use plenary.scandir to do such a thing?

@Conni2461
Copy link
Collaborator

Windows is currently not supported.

I tried to make it work, also with moving to scandir, but everytime i fixed an issue 10 more poped up. Maybe you wanna do it, i dont have a windows system so it was a nightmare to try to fix it.

Here is my work:
https://github.com/nvim-lua/plenary.nvim/pull/74/files#diff-503c6d245571ab4d81c154079fb5736a3276b23ec1f97f09d826821f4c80168fR1

@ckipp01
Copy link
Contributor

ckipp01 commented Feb 5, 2022

Windows is currently not supported.

Just to clarify, is this still the case? If not, do you know of any examples out in the wild of running the plenary test harness on windows? Pretty much any issues I get reported that has to do with plenary is always regarding something to do with windows, so I'd love to be able to test for this. I also see that Plenary itself doesn't test on windows? Is that intentional because it's not supported, or an oversight, or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants