cleanup: remove ftdetect file as Neorg is now natively recognized by Neovim
#1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTBBloodbath
requested review from
vhyrro,
mrossinek and
danymat
as code owners
|
this can just be merged after 0.10 release right? |
Yeah, we've decided to merge this once 0.10 is released. We will also nuke ftdetect along with this PR then |
|
well then you could also nuke it in this pr then ig |
|
Not sure how plenary filetype detection works but ig we could also remove this then: |
NTBBloodbath
force-pushed
the
filetype-cleanup
branch
from
201ecc4
to
9699dbc
Compare
NTBBloodbath
force-pushed
the
filetype-cleanup
branch
from
9699dbc
to
fb4fa24
Compare
NTBBloodbath
changed the title
vim.filetype logic in setupftdetect file as Neorg is now natively recognized by Neovim
|
Updated title and rebased to update according to the latest codebase changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove
vim.filetypelogic in setup as it is already covered by the ftdetect file.FYI: ftdetect directory is going to be deleted once Neovim v0.10 release is stable as I've added support for norg filetype in Neovim's core.