Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lua-api): add rocks.packadd function #214

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat(lua-api): add rocks.packadd function #214

merged 1 commit into from
Mar 21, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Mar 20, 2024

Closes #213

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb force-pushed the rocks-packadd-lua-function branch from 38b34ea to 123adae Compare March 20, 2024 18:12
vhyrro
vhyrro approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@vhyrro vhyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrcjkb mrcjkb merged commit ad6cd44 into master Mar 21, 2024
6 checks passed
@mrcjkb mrcjkb deleted the rocks-packadd-lua-function branch March 21, 2024 16:18
@mrcjkb mrcjkb mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro vhyrro approved these changes

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Public lua API for :Rocks packadd function
2 participants
@mrcjkb @vhyrro