Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): install function for installing rocks with a callback #217

Merged
merged 2 commits into from
Mar 23, 2024
Merged

feat(api): install function for installing rocks with a callback #217

merged 2 commits into from
Mar 23, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Mar 21, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb
Copy link
Member Author

mrcjkb commented Mar 23, 2024

Merging, as this is quite trivial

@mrcjkb mrcjkb merged commit 0df5915 into master Mar 23, 2024
6 checks passed
@mrcjkb mrcjkb deleted the install-callback branch March 23, 2024 16:07
@mrcjkb mrcjkb mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrcjkb