Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): append start plugins to rtp before calling preload hooks #267

Merged
merged 2 commits into from
Apr 13, 2024
Merged

fix(runtime): append start plugins to rtp before calling preload hooks #267

merged 2 commits into from
Apr 13, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Apr 11, 2024

Closes #237.

This fixes the loading order issue (e.g. colorschemes) for rocks-config.nvim:

  1. Append start plugins to the rtp
  2. Call preload hooks -> rocks-config.nvim
  3. Source plugin directories

With this, I don't think rocks-config needs to worry about providing before or after config mechanisms.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb merged commit f86ffe6 into master Apr 13, 2024
7 checks passed
@mrcjkb mrcjkb deleted the rtp_append-before-preload_hooks branch April 13, 2024 13:17
@mrcjkb mrcjkb mentioned this pull request Apr 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath NTBBloodbath approved these changes

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[needs triage] colorschemes added to rtp after init.lua is sourced
2 participants
@mrcjkb @NTBBloodbath