Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version check to installer and plugin script #277

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Apr 14, 2024

The neovim version requirement in the readme can be overlooked, leading to people opening issues.

Copy link
Contributor

github-actions bot commented Apr 14, 2024

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

NTBBloodbath
NTBBloodbath previously approved these changes Apr 15, 2024
@mrcjkb
Copy link
Member Author

mrcjkb commented Apr 15, 2024

This isn't working on Windows. Weird...

@mrcjkb mrcjkb marked this pull request as draft April 15, 2024 07:05
@mrcjkb mrcjkb marked this pull request as ready for review April 15, 2024 21:47
@mrcjkb mrcjkb enabled auto-merge (squash) April 15, 2024 21:48
@mrcjkb mrcjkb merged commit c54d6e2 into master Apr 15, 2024
7 checks passed
@mrcjkb mrcjkb deleted the version-check branch April 17, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants