Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): bug causing : to be appended to version in rocks.toml #62

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Dec 9, 2023

Fixes #57.

Note: This is stacked on #58 to prevent merge conflicts.

Tested manually according to the steps in #57.

@mrcjkb mrcjkb self-assigned this Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

This comment has been minimized.

@mrcjkb mrcjkb requested a review from teto as a code owner December 10, 2023 01:53
@mrcjkb mrcjkb force-pushed the fix-rocks-toml-version branch from f34abe3 to 45c66c7 Compare December 10, 2023 02:00
@mrcjkb mrcjkb force-pushed the fix-rocks-toml-version branch from 45c66c7 to f16aeff Compare December 10, 2023 12:53
Base automatically changed from fidget to master December 10, 2023 19:53
@mrcjkb mrcjkb force-pushed the fix-rocks-toml-version branch from f16aeff to 5f2832f Compare December 10, 2023 22:20
@mrcjkb mrcjkb merged commit 8e8ceec into master Dec 11, 2023
4 of 6 checks passed
@mrcjkb mrcjkb deleted the fix-rocks-toml-version branch December 11, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Rocks install sometimes appends : to version in rocks.toml
1 participant