Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logging + :Rocks log command #65

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: logging + :Rocks log command #65

merged 1 commit into from
Dec 11, 2023

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Dec 11, 2023 •
edited
Loading

Note that this is stacked on top of #63

Test steps:

  • Edit rocks.toml
  • :Rocks sync
  • :Rocks log

Closes #55.

@mrcjkb mrcjkb self-assigned this Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb linked an issue Dec 11, 2023 that may be closed by this pull request
[Feature]: Keep track of luarocks errors #55
Closed
@mrcjkb mrcjkb mentioned this pull request Dec 11, 2023
Merged
Base automatically changed from fix-sync-prunes to master December 11, 2023 17:14
@mrcjkb mrcjkb merged commit 4a0678d into master Dec 11, 2023
4 of 6 checks passed
@mrcjkb mrcjkb deleted the rocks-log branch December 11, 2023 17:16
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees

@mrcjkb mrcjkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Keep track of luarocks errors
1 participant
@mrcjkb