Fix: Test watch won't start on v0.10.1 #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the version v0.10.1, supports_method is still a table, rather than a function. Code was trying to call a regular table field as a function, resulting in following error: attempt to call field 'supports_method' (a table value) Now the type of the client.supports_method is checked beforehand, instead of accessing the method right away.
|
My fault. I was distracted in #451 because of neotest not working in the neovim nightly version. I was preparing a fix for this as well and I have just one correction. |
rcasia
reviewed
Sep 25, 2024
Basically 1:1 code @rcasia proposed.
straightchlorine
force-pushed
the
watch-init-fix
branch
from
0e9bd38 to
9a302db
Compare
tftiwnbe
approved these changes
Sep 29, 2024
rcasia
approved these changes
Sep 29, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the version v0.10.1, supports_method is still a table, rather than a function. Trying to access the table field as a function resulted in following error:
This behavior is now fixed.