Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #8

Open
lyz-code opened this issue Feb 9, 2024 · 1 comment
Open

Add tests #8

lyz-code opened this issue Feb 9, 2024 · 1 comment
Labels
developer experience Improvements to the quality of the code base

Comments

@lyz-code
Copy link
Collaborator

lyz-code commented Feb 9, 2024

I have absolutely no idea of lua, I'm learning as I debug this plugin.

It may come the day that I'm able to write tests, if you're reading this and feel sorry for me and want to give your 2 cents, please make a PR with some tests.

@seflue
Copy link
Collaborator

seflue commented May 24, 2024

Tests would make absolutly sense to increase the confidence in our changes. It would need a couple of refactorings though to make the business logic of the plugin testable.
I will think about how to make this happen. If someone has some spare time and can point to telescope extensions, which already have setup some good tests, this would be helpful.

@seflue seflue added the developer experience Improvements to the quality of the code base label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Improvements to the quality of the code base
Projects
None yet
Development

No branches or pull requests

2 participants