Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of git_files to show_untracked=false #826

Closed
kaddkaka opened this issue May 8, 2021 · 1 comment · Fixed by #842
Closed

Change default of git_files to show_untracked=false #826

kaddkaka opened this issue May 8, 2021 · 1 comment · Fixed by #842
Labels
enhancement Enhancement to performance, inner workings or existent features

Comments

@kaddkaka
Copy link
Contributor

kaddkaka commented May 8, 2021

Problem: git_files has an unexpected default of listing untracked files.
Suggestion: make the default of git_files not list untracked files.

:Telescope git_files currently lists all files in a git repo folder; the default is to also list untracked files. This is not the same default as git and other tools have. For example

  • git ls-files lists all tracked files in the repo and a flag is needed to list untracked files as well.
  • fzf.vim's :GFiles lists tracked files (has :GFiles? to list untracked files as well)

It is possible to list tracked files with lua require"telescope.builtin".git_files({ show_untracked = false }) but I think that the default behavior is unexpected. The first time I tried telescope I thought that git_files was broken because it acted just like find_files.

Related: There is already git_status which can be used to find new untracked files in the repo.

@kaddkaka kaddkaka added the enhancement Enhancement to performance, inner workings or existent features label May 8, 2021
@Conni2461
Copy link
Member

#842 was merged into dev branch. Please read #1938 if you want to know when it hits master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to performance, inner workings or existent features
Projects
None yet
2 participants