Skip to content

chore: remove side top / bottom #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-courtis opened this issue Sep 20, 2022 · 3 comments
Closed

chore: remove side top / bottom #1595

alex-courtis opened this issue Sep 20, 2022 · 3 comments

Comments

@alex-courtis
Copy link
Member

Side top/bottom are not completely functional and show some inconsistencies.
Remove them.
Side not top/bottom/left/right has catastrophic results.

Migration options:

  • silently default anything but left/right to left
  • explicitly validate side left/right
@alex-courtis
Copy link
Member Author

fbd421d

@cmlaverdiere
Copy link

I was using side: bottom with this plugin and it was working fine for me, and I didn't notice any issues. Would you be willing to re-add them in with a warning that they aren't fully functional?

@alex-courtis
Copy link
Member Author

I was using side: bottom with this plugin and it was working fine for me, and I didn't notice any issues. Would you be willing to re-add them in with a warning that they aren't fully functional?

A lot of things were broken with top/bottom, and functionality has subsequently been built that assumes left/right/float positioning.

What is the use case? A file explorer is tall and would result in a lot of wasted space when shown full width at the bottom or top of a normal wide-rectangular terminal. If you've got some other windows in your layout perhaps we could come up with some alternate means to arrange tall tree windows in your desired position.

I'm open to putting the functionality back in, but only in a "works everywhere" state. You could raise a PR to do this, however we will need to do extensive testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants