Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "METHOD=script" WSL install tests #2665

Closed
ljharb opened this issue Nov 28, 2021 · 1 comment · Fixed by #2668
Closed

Fix "METHOD=script" WSL install tests #2665

ljharb opened this issue Nov 28, 2021 · 1 comment · Fixed by #2668
Labels
OS: windows pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.

Comments

@ljharb
Copy link
Member

ljharb commented Nov 28, 2021

The method=script install tests are failing due to wget/curl not being found, despite them being in additional_packages in the setup-wsl github action.

We need to re-enable these tests.
@ljharb ljharb added OS: windows testing Stuff related to testing nvm itself. pull request wanted This is a great way to contribute! Help us out :-D labels Nov 28, 2021
@ljharb
Copy link
Member Author

ljharb commented Nov 28, 2021

cc @nmarghetti

@ljharb ljharb mentioned this issue Nov 30, 2021
Merged
@ljharb ljharb closed this as completed in 4856407 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS: windows pull request wanted This is a great way to contribute! Help us out :-D testing Stuff related to testing nvm itself.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] install: fix method=script install condition
1 participant
@ljharb