Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to jupyter notebook 5 #71

Open
darthoctopus opened this issue Apr 21, 2017 · 2 comments
Open

update to jupyter notebook 5 #71

darthoctopus opened this issue Apr 21, 2017 · 2 comments

Comments

@darthoctopus
Copy link

Jupyter notebooks 5 and ipython 6 introduce Jedi integration for ipython. With the codebase unmodified,

  • Some callbacks are broken (most notably, saving checkpoints, and saving on quit)
  • Kernel selection is also broken (no kernels are read into the menu)

After fiddling around, I've found that the last issue stems from a change in either main.js or main.min.js in static/notebook/js. I'm not sure what is causing the broken callbacks.

@darthoctopus
Copy link
Author

update: the broken callbacks were caused by the notebook_loaded.Notebook event in custom.js not being invoked on document load. As a workaround I've bound it to be triggered on command_mode. This is likely a Jupyter bug. Everything works beautifully otherwise.

@gandalfsaxe
Copy link

Is it updated yet? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants