Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen mode not true fullscreen - windows behind NW.js still being rendered #7019

Closed
rogerscg opened this issue Mar 18, 2019 · 7 comments

Comments

@rogerscg
Copy link

rogerscg commented Mar 18, 2019

NWJS Version : 30.4
Operating System : Windows 10 64 Bit

Expected behavior

Setting fullscreen: true uses true fullscreen, preventing windows behind the app to be rendered.

Actual behavior

When using fullscreen: true, the app behaves as borderless windowed, not true fullscreen.

How to reproduce

I'm using this package.json:

    "title": "My App",
    "frame": false,
    "width": 800,
    "height": 600,
    "icon": "assets/textures/icon.png",
    "fullscreen": true,
    "toolbar": false
  },
  "chromium-args": "--in-process-gpu --disable-transparency"

The game starts in full screen, but it's not a true fullscreen.

@ffanny
Copy link
Member

ffanny commented Mar 19, 2019

Would you please provide a screenshot or other things to show that it is not a true fullscreen?
I test with nwjs-sdk-v0.30.4-win, and it starts in fullscreen like the screenshot below.
And I check the fullscreen state with win.isFullscreen and check again after win.leaveFullscreen(). The result are ture and false.
fullscreen screenshot
fullscreen state

@TheRealDannyyy
Copy link

TheRealDannyyy commented Mar 19, 2019

@ffanny I think the reporter tries to point out that NWjs is using borderless-window fullscreen instead of native fullscreen (e.g. with full control over the brightness and resolution of the screen).

@rogerscg
Copy link
Author

@ffanny I think the reporter tries to point out that NWjs is using borderless-window fullscreen instead of native fullscreen (e.g. with full control over the brightness and resolution of the screen).

That's correct @TheRealDannyyy.

@rogerwang
Copy link
Member

Thanks for reporting. If you mean exclusive fullscreen mode that bypasses window manager, I'm afraid that current Chromium doesn't support it. We'll support it after when Chromium does so. See also w3c/html#375

@stale
Copy link

stale bot commented Mar 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2020
@stale stale bot closed this as completed Mar 17, 2020
@MistakingManx
Copy link

any updates? I want it to overlay overtop Minecraft Bedrock edition when it's full screened. Or any exclusive full screen app for that matter.

My app is an overlay service.

@MistakingManx
Copy link

I had a weird interaction where it worked randomly for an hour or so and then stopped working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants