Between 0.46.0-beta1 and 0.46.0 a change to Windows parsing of "chromium-args" in package.json truncates it to a length of MAX_PATH (260 characters).

[sirisian]

NWJS Version : 0.46.0+
Operating System: Only Windows

Expected behavior

"chromium-args" of any length should be parsed.

"chromium-args": "--user-data-dir='./chromium-config' --use-fake-ui-for-media-stream --disable-site-isolation-trials --autoplay-policy=no-user-gesture-required --enable-file-cookies --ignore-certificate-errors --allow-file-access-from-files --allow-http-background-page --allow-external-pages --allow-running-insecure-content --allow-hidden-media-playback --disable-user-media-security --register-pepper-plugins='./node_modules/mpv.js/build/Release/mpvjs.node;application/x-mpvjs'"

(I know some of those flags are no longer valid, just an example).

Actual behavior

The "chromium-args" truncates and only seems to process the first 260 characters silently ignoring the rest. This can cause very unexpected and subtle bugs when upgrading past 0.46.0-beta1.

How to reproduce

Add in a bunch of flags like I have and it'll ignore the ones after 260 characters.

Refer to the changes made to "src/nw_package.cc" in this diff:

nw-v0.46.0-beta1...nw-v0.46.0

The following code was added that I think caused this:

  // Expand Windows psudovars (ex; %APPDATA%) passed in chromium-args in the same way as when 
  // passed as command line parameters.
  #if defined(OS_WIN)
  TCHAR szEnvPath[MAX_PATH];
  std::wstring ws; 
  ws.assign( args.begin(), args.end());
  if (ExpandEnvironmentStrings(ws.c_str(), szEnvPath,MAX_PATH) != 0) {
    std::wstring ws_out = szEnvPath;
    args = std::string(ws_out.begin(), ws_out.end());
  } else {
    ReportError("Failed to expand chromium args",args.c_str());
  }
  #endif

One could just naively replace MAX_PATH to a larger number like 10000 or correctly handle this by growing an array with the value returned by ExpandEnvironmentStrings?

[TheRealDannyyy]

This is also affecting some projects of mine. Would appreciate a review and merge of the PR @rogerwang.

[ayushmanchhabra]

@sirisian I looked at the PR related to this. Should we instead have a flag which dynamically sets the character limit higher than 260 with an upper limit of 32,000? Let's say the user's chromium-args character length is 268 which is only 8 above the limit. It probably wouldn't make sense to allocate all that extra memory if it isn't going to be used (forgive me if I misunderstood the way memory is handled)? Or we could instead keep the limit of 260 characters and add a note about it in the documentation.

cc @rogerwang

[Arzenar]

It would be great to increase it dynamically as many use nw.js for games or other GPU and media related things. There are many Chromium args that support this type of use case. Now if it stays at a size of 260, that would be extremely obstructive.

[zkrige]

This is currently blocking us on over 500 000 devices. We urgently need a fix here. @rogerwang would it be possible to fix this in 0.92.0 Please 🙏

[zkrige]

Is there anything I can do here to speed this up? We urgently need this resolved...

[zkrige]

@rogerwang is there anything I can do to help move this along?