Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Event 'open' stop works after once triggered #7969

Closed
panther7 opened this issue Sep 22, 2022 · 7 comments
Closed

BUG: Event 'open' stop works after once triggered #7969

panther7 opened this issue Sep 22, 2022 · 7 comments
Assignees

Comments

@panther7
Copy link

  • NWjs 0.66.1 - ok
  • NWjs 0.67.1 - ok
  • NWjs 0.68.1 - fail

Windows 11 22H2 (22622.601) x64

index.html

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>Demo</title>
  </head>
  <body>
    <script>
      nw.App.on('open', (params) => {
        console.log(params);
      });
  
      setTimeout(() => nw.Window.get().showDevTools(), 100);    
    </script>
  </body>
</html>
@panther7
Copy link
Author

Maybe again as #7860.

@rogerwang

@panther7
Copy link
Author

Hmmm... roger, you did deleted line after merge chromium 105 ...mistake?

2022-09-22 16 06 10

@rogerwang rogerwang self-assigned this Sep 22, 2022
@rogerwang
Copy link
Member

Thanks for finding this. Some modifications were left behind when upgrading to Chromium 105. Will apply them all.

@ayushmanchhabra
Copy link
Contributor

Would it be better to apply this change (and similar) as a .patch file so deps roll doesn't change the nwjs modifications?

@rogerwang
Copy link
Member

It doesn't matter. Most of the modifications is in Chromium repo and I need to re-apply them from version to version.

@ayushmanchhabra
Copy link
Contributor

I understand that. My question is are the list of modifications saved somewhere or do you know them by memory (trying to understand the codebase)?

@rogerwang
Copy link
Member

It's a single big master patch. You can get it by comparing NW with the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants