Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: Using v0.10.1-1 #51

Closed
1j01 opened this issue Aug 13, 2014 · 2 comments
Closed

ERROR: Using v0.10.1-1 #51

1j01 opened this issue Aug 13, 2014 · 2 comments

Comments

@1j01
Copy link
Contributor

1j01 commented Aug 13, 2014

(Manually specifying a version works.)

Latest Version: v0.10.1-1
Using v0.10.1-1
Create cache folder in C:\Users\Isaiah\Code\GitHub\node-webkit-builder\cache\0.10.1-1
Downloading: http://dl.node-webkit.org/v0.10.1-1/node-webkit-v0.10.1-1-win-ia32.zip
ERROR: The version 0.10.1-1 does not have a corresponding build posted at http://dl.node-webkit.org/. Please choose a version from that list.
Unable to download nodewebkit.

The package nodewebkit is at 0.10.1-1 so it tries to dl 0.10.1-1 whereas http://dl.node-webkit.org/ has v0.10.2, which it ought to somehow find.

Should this be taken up as an issue on https://github.com/shama/nodewebkit to release v0.10.2? Why are we taking the versions from "An installer for node-webkit"? Scraping seems more reliable, as long as http://dl.node-webkit.org/ stays as an index listing.

At any rate, we can't expect the package not to have intermediate versions. Maybe we should just strip out the dash part.

@gabepaez
Copy link
Contributor

We were trying to avoid scraping from the apache directory listing. That being said, it's looking like that would be more reliable then depending on the nodewebkit repo staying in sync with node-webkit. You make an excellent point here and I like the idea of eliminating the npm dependency. Any chance you could contribute a PR that makes this look good?

@1j01
Copy link
Contributor Author

1j01 commented Aug 14, 2014

I just found that there is a function filterVersions(data) that's supposed to filter out patch/build versions, but it looks like it's not being used in getLatestVersion which is probably the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants