You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Latest Version: v0.10.1-1
Using v0.10.1-1
Create cache folder in C:\Users\Isaiah\Code\GitHub\node-webkit-builder\cache\0.10.1-1
Downloading: http://dl.node-webkit.org/v0.10.1-1/node-webkit-v0.10.1-1-win-ia32.zip
ERROR: The version 0.10.1-1 does not have a corresponding build posted at http://dl.node-webkit.org/. Please choose a version from that list.
Unable to download nodewebkit.
The package nodewebkit is at 0.10.1-1 so it tries to dl 0.10.1-1 whereas http://dl.node-webkit.org/ has v0.10.2, which it ought to somehow find.
We were trying to avoid scraping from the apache directory listing. That being said, it's looking like that would be more reliable then depending on the nodewebkit repo staying in sync with node-webkit. You make an excellent point here and I like the idea of eliminating the npm dependency. Any chance you could contribute a PR that makes this look good?
I just found that there is a function filterVersions(data) that's supposed to filter out patch/build versions, but it looks like it's not being used in getLatestVersion which is probably the problem.
(Manually specifying a version works.)
The package nodewebkit is at
0.10.1-1
so it tries to dl0.10.1-1
whereas http://dl.node-webkit.org/ hasv0.10.2
, which it ought to somehow find.Should this be taken up as an issue on https://github.com/shama/nodewebkit to release
v0.10.2
? Why are we taking the versions from "An installer for node-webkit"? Scraping seems more reliable, as long as http://dl.node-webkit.org/ stays as an index listing.At any rate, we can't expect the package not to have intermediate versions. Maybe we should just strip out the dash part.
The text was updated successfully, but these errors were encountered: