We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve()
compress()
nw-builder/src/bld/compress.js
Line 21 in dfae361
For file streams, theresolve() should be in the close event listener, not end. The end event never fires, so this promise never resolves.
close
end
The text was updated successfully, but these errors were encountered:
Oh weird, compressing the zip files worked for me so I never checked to look if the promise resolved or not
Sorry, something went wrong.
As mentioned in #696, you should also reject with the error message instead of "1". Put the console.log() further down the stack.
console.log()
Successfully merging a pull request may close this issue.
nw-builder/src/bld/compress.js
Line 21 in dfae361
For file streams, the
resolve()
should be in theclose
event listener, notend
. Theend
event never fires, so this promise never resolves.The text was updated successfully, but these errors were encountered: