Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve() is in the wrong event listener for compress() #692

Closed
sysrage opened this issue Nov 19, 2022 · 2 comments · Fixed by #698
Closed

resolve() is in the wrong event listener for compress() #692

sysrage opened this issue Nov 19, 2022 · 2 comments · Fixed by #698
Labels
bug Priority: 1

Comments

@sysrage
Copy link
Contributor

sysrage commented Nov 19, 2022

For file streams, theresolve() should be in the close event listener, not end. The end event never fires, so this promise never resolves.

@sysrage sysrage added the bug Priority: 1 label Nov 19, 2022
@ayushmanchhabra
Copy link
Collaborator

Oh weird, compressing the zip files worked for me so I never checked to look if the promise resolved or not

@sysrage
Copy link
Contributor Author

sysrage commented Nov 20, 2022

As mentioned in #696, you should also reject with the error message instead of "1". Put the console.log() further down the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants