Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed manifest #842

Closed
1 of 3 tasks
ayushmanchhabra opened this issue Apr 14, 2023 · 0 comments · Fixed by #965
Closed
1 of 3 tasks

Managed manifest #842

ayushmanchhabra opened this issue Apr 14, 2023 · 0 comments · Fixed by #965
Assignees
Labels
feature Priority: 2

Comments

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Apr 14, 2023

Issue Type

  • Bug Report
  • Feature Request
  • Other

Current/Missing Behaviour

The NW manifest has to be managed by the programmer. A build step or seperate package.json is required which acts as a NW manifest.

Expected/Proposed Behaviour

If options.managedManifest is enabled, it would parse the Node manifest (package.json at the project root and copy all NW.js relevant properties to the NW manifest inside package.nw. User will also have option to edit those properties (to omit a property, set it to undefined).

A common NW.js Web App development setup would be:

.package.json

{
  "name": "demo-app",
  "version": "0.0.0-development",
  "main": "http://localhost:4200",
  "node-remote": "http://localhost:4200",
}

By enabling managedManifest:

package.nw/package.json

{
  "name": "AppName",
  "version": "1.2.3",
  "main": "index.html",
}

Additional Info

  • This brings nw-builder one step closer to nwjs-builder-pheonix in terms of feature parity.
  • Exact API is TBD but discussions are welcome.
  • Blocked by refactor: build mode #951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Priority: 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant