Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of the sync command without a matching acmd lead to a stack corruption #13

Open
AlbanBedel opened this issue Aug 12, 2021 · 1 comment

Comments

@AlbanBedel
Copy link

If an auto file use the sync command without a matching acmd, for example because of some naive copy&paste, then FD_SET() is called with g_stdout set to -1. This corrupt the stack which might go unnoticed, but if glibc has fortify support it will abort right away.

Even it is not a valid command sequence I think ufb should issue a warning and just ignore the command instead of corrupting the stack.

@nxpfrankli
Copy link
Contributor

it is another project.
https://github.com/NXPmicro/imx-uuc/blob/master/ufb.c

May be crash at.
FD_SET(g_stdout, &rfds);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants