This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Fix Angular dependency type #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating an Nx workspace, the @nrwl/angular package is added to the dependencies key in package.json. And when an application is added using @nxtend/ionic-angular it will unconditionally add it to devDependencies key.
And a small fix in CONTRIBUTING file.
PR Checklist
Issue
See #621 for further information.
Although I think this is an improvement, there may be an issue when 'nrwl' packages have a different version number from what 'nxtend' sets
@nrwl/angular, when needed. Internally, 'nrwl' has a lot of checks for dependency mismatch, as seen here. I guess my point here, to me it seems 'nrwl' plugins are high maintenance. And more edits can and will be needed in the code that has been changed for this PR.Resolves #621