Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): upgrade to Nx 14 #638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rhutchison
Copy link

Description

PR Checklist

  • Migrations have been added if necessary
  • Unit tests have been added or updated if necessary
  • e2e tests have been added or updated if necessary
  • Changelog has been updated if necessary
  • Documentation has been updated if necessary

Issue

Resolves #628

@rhutchison rhutchison marked this pull request as ready for review July 10, 2022 20:53
@mcz-xiocku
Copy link

It would be amazing to have this update !

@Destreyf
Copy link

Destreyf commented Jul 18, 2022

@rhutchison I pulled this down and used it locally myself and it seems to work great, however one thing I would like to note is it looks like this still uses @ionic/angular version ^5.8.3 but I needed to install version 6.1.X (in my case its 6.1.14) in order to get it working with angular 14.

I was able to simply npm install @ionic/angular@latest and it fixed my build issues.

@rhutchison
Copy link
Author

Thanks, I will check the dependencies and update. I was using ionic 6 in my project.

@rhutchison
Copy link
Author

@Destreyf I think the upgrade to ionic 6 should be a separate PR.

Also, it sounds like @devinshoemaker has some other things in the works, that might supersede this PR.

@sagarkm
Copy link

sagarkm commented Jul 20, 2022

Would this PR fix the same "Cannot find module 'nx/src/utils/app-root'" issue for @nxtend/ionic-react as well?

@Destreyf
Copy link

@sagarkm Based on a very quick scan on the files modified, it looks like similar modifications used to fix ionic-angular were applied to the ionic-react so it should in theory work.

It's possible that other issue(s) exist around the ionic-react, I tested this PR against my angular project and it worked like a charm.

Copy link

@orl99 orl99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, can we merge this PR ASAP?

@orl99
Copy link

orl99 commented Jul 28, 2022

Is there any news in the merge process?

@m8xp0w3r
Copy link

@Destreyf I think the upgrade to ionic 6 should be a separate PR.

Also, it sounds like @devinshoemaker has some other things in the works, that might supersede this PR.

@rhutchison and @devinshoemaker this sounds cool. Can you give us a rough estimate of when this will come?

@Destreyf Destreyf mentioned this pull request Aug 1, 2022
@dolphinigle
Copy link

This also resolves #633

@devinshoemaker
Copy link
Collaborator

👋 I have been working with the Nxext team to migrate these plugins into their monorepo to make maintaining these plugins a lot easier. It's been a lot of work over the last couple years maintaining this project, and consolidating these plugins into a single repo will help keep these plugins around by sharing the load among several maintainers. Nx 14 support is now available once you migrate to Nxext. Here's some info on migrating the Ionic Angular plugin, and there's also migration guides for Ionic React and Capacitor.

https://nxext.dev/docs/ionic-angular/migrating-from-nxtend.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx 14 support
9 participants