-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): upgrade to Nx 14 #638
base: main
Are you sure you want to change the base?
Conversation
It would be amazing to have this update ! |
@rhutchison I pulled this down and used it locally myself and it seems to work great, however one thing I would like to note is it looks like this still uses I was able to simply |
Thanks, I will check the dependencies and update. I was using ionic 6 in my project. |
@Destreyf I think the upgrade to ionic 6 should be a separate PR. Also, it sounds like @devinshoemaker has some other things in the works, that might supersede this PR. |
Would this PR fix the same "Cannot find module 'nx/src/utils/app-root'" issue for @nxtend/ionic-react as well? |
@sagarkm Based on a very quick scan on the files modified, it looks like similar modifications used to fix ionic-angular were applied to the ionic-react so it should in theory work. It's possible that other issue(s) exist around the ionic-react, I tested this PR against my angular project and it worked like a charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, can we merge this PR ASAP?
Is there any news in the merge process? |
@rhutchison and @devinshoemaker this sounds cool. Can you give us a rough estimate of when this will come? |
This also resolves #633 |
👋 I have been working with the Nxext team to migrate these plugins into their monorepo to make maintaining these plugins a lot easier. It's been a lot of work over the last couple years maintaining this project, and consolidating these plugins into a single repo will help keep these plugins around by sharing the load among several maintainers. Nx 14 support is now available once you migrate to Nxext. Here's some info on migrating the Ionic Angular plugin, and there's also migration guides for Ionic React and Capacitor. https://nxext.dev/docs/ionic-angular/migrating-from-nxtend.html |
Description
PR Checklist
Issue
Resolves #628