Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tel Parsing should deal with full tel URNs better #41

Open
nicpottier opened this issue Jan 11, 2021 · 2 comments
Open

Tel Parsing should deal with full tel URNs better #41

nicpottier opened this issue Jan 11, 2021 · 2 comments

Comments

@nicpottier
Copy link
Contributor

urns.NewTelURNForCountry("tel:+12065551212", "US") -> tel:+tel12065551212

Which seems mighty unfortunate considering how many people probably intuitively want to use @urns.tel as the argument to things that expect a telephone number.

Detecting we are given a tel URN seems like it would probably be worth it? What are possible downsides there?

Also feels super weird that the current behavior ends up with + prefixed on the returned number.

@rowanseymour feels liken number parsing this has been under a lot of flux lately, any opinions here?

@rowanseymour
Copy link
Member

Yeah that seems reasonable - tel: afterall isn't just a RP pro thing. Where are we seeing this?

@nicpottier
Copy link
Contributor Author

Just noticed it myself when writing a unit test and wanting to pass @contact.tel as a phone number. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants