Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get start_local_network.sh working with the js example #227

Closed
futurechimp opened this issue May 12, 2020 · 0 comments · Fixed by #228 or #1326
Closed

Get start_local_network.sh working with the js example #227

futurechimp opened this issue May 12, 2020 · 0 comments · Fixed by #228 or #1326
Assignees
Milestone

Comments

@futurechimp
Copy link
Contributor

The --manifest-path from script/start_local_network.sh is extremely frustrating. Whenever I make a change in application code and then try it out using start_local_network, I get a super-convenient two minute rebuild for no reason other than the allegedly time-saving cfg(env) setup.

If I then try to change and rebuild my code back in "normal" cfg, try it out, maybe run unit tests, I then get another two minute rebuild, and then when I go to try it out again in cluster mode, I get another two minute rebuild. It's killing me.

Next up: the directory server parameter never gets written to the config.toml file. Every time I try to add in a --directory parameter to the start_local_network.sh script so that I can do what should be simple quality assurance in the clustered environment (a) the --directory option that I pass in is ignored by the nodes, and in fact (b) the value I've explicitly told it to use is totally ignored by the mixnode config file writer (and presumably other kinds of nodes too) for reasons I don't understand.

I've looked through the nodes and attempted to trace wherever it is that I need to explicitly add in the value for the directory server, but that's not obvious.

There is such a thing as being too clever trying to anticipate a user's wishes. Please get rid of every "magic" value in the configs of all node types:

a) lose the cfg(qa)and cfg(local) out of all Cargo.toml files (note that there is one wasm-related one that does need to stay). Whatever "convenience" that setup was meant to supply isn't worth six minutes of my life every time I want to make the simplest change and try it out while switching back and forth between clustered and non-clustered testing. Trying a few quick changes takes 20 minutes rather than 30 seconds.

b) set things up so that when I tell my computer to write out a configuration value to a configuration file, the configuration value is actually written to the configuration file. We will need to fight the machines later with our laser pistols, there's no sense giving them a head-start on the free will thing.

Finally, once the prep work is done, please add the explicit --directory 127.0.0.1:8080 in the start_local_network.sh script, ensure the proper processes are started/stopped (replace sfw-provider with gateway). Pick a port to run the gateway on that agrees with the JavaScript and I'll take it over to write docs again once the basic setup is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
2 participants