Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user friendly element ID's in the nym-wallet #2584

Closed
tommyv1987 opened this issue Oct 13, 2021 · 1 comment
Closed

Implement user friendly element ID's in the nym-wallet #2584

tommyv1987 opened this issue Oct 13, 2021 · 1 comment
Labels
chore Updating dependencies, fixing CI, etc

Comments

@tommyv1987
Copy link
Contributor

tommyv1987 commented Oct 13, 2021

Description

In the nym_wallet some elements have easily identifiable ID's, yet the majority of the wallet have long path selectors:

Can we update the elements in the project to resemble:

get sphinxKey() {
    return $("#sphinxKey");
  }

Quite a lot of the elements in the project have long hard to distinguish selectors, like below:

  get advancedOptions() {
    return $("#root > div > div:nth-child(2) > div:nth-child(2) > div > div > div > div.MuiCardContent-root > div.MuiFormControl-root.MuiFormControl-fullWidth > div:nth-child(1) > div > div:nth-child(8) > label > span.MuiButtonBase-root.MuiIconButton-root.PrivateSwitchBase-root-13.MuiCheckbox-root.MuiCheckbox-colorSecondary.MuiIconButton-colorSecondary > span.MuiIconButton-label > input");
  }

  get selectAdvancedOptions() {
    return $("#root > div > div:nth-child(2) > div:nth-child(2) > div > div > div > div.MuiCardContent-root > div.MuiFormControl-root.MuiFormControl-fullWidth > div:nth-child(1) > div > div:nth-child(8) > label > span.MuiButtonBase-root.MuiIconButton-root.PrivateSwitchBase-root-7.MuiCheckbox-root.MuiCheckbox-colorSecondary.MuiIconButton-colorSecondary");

  }

Therefore, if we continue to automate the GUI on the wallet, updating elements and attributes will be a quick task.

@tommyv1987 tommyv1987 added the chore Updating dependencies, fixing CI, etc label Oct 13, 2021
@tommyv1987
Copy link
Contributor Author

PR - raised - #836

@futurechimp futurechimp transferred this issue from another repository Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating dependencies, fixing CI, etc
Projects
None yet
Development

No branches or pull requests

1 participant