Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly used Arcs #47

Closed
jstuczyn opened this issue Jan 10, 2020 · 0 comments · Fixed by #125
Closed

Fix incorrectly used Arcs #47

jstuczyn opened this issue Jan 10, 2020 · 0 comments · Fixed by #125
Assignees
@jstuczyn

Comments

@jstuczyn
Copy link
Contributor

When we're processing client requests (say in provider), we keep processing data as Arc<some struct> this only happens to work because some struct implements Copy. This should be Arc<RefCell<some struct>> or <Arc<Cell<some struct>> instead.
@futurechimp futurechimp added this to the 0.4.0 milestone Jan 20, 2020
@jstuczyn jstuczyn mentioned this issue Jan 22, 2020
Merged
@futurechimp futurechimp removed this from the 0.4.0 milestone Jan 24, 2020
@jstuczyn jstuczyn self-assigned this Feb 27, 2020
@jstuczyn jstuczyn mentioned this issue Mar 3, 2020
Merged
@mmsinclair mmsinclair moved this to Done in Core systems May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstuczyn jstuczyn

Labels
None yet
Projects
No open projects
Core systems
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/provider refactoring nymtech/nym
2 participants
@futurechimp @jstuczyn