You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've also hit this same issue when trying to use this package with Vite 5+, which writes the manifest to ${outDir}/.vite/manifest.json. Everything works great with Vite dev server, but the incorrect hardcoded part of the manifest path means no assets are registered when in production / build mode.
It should be an easy lift and would extend the lifetime / usefulness of this package, especially given that Vite is now on v6. Currently a protected class constant is used for the manifest file name. All that's really needed here is for that to be a public property instead, so that it can be overridden.
I've worked around this by subclassing VitePluginService to set the correct path, but it would be much nicer to just be able to pass the manifest path + filename relative to the output dir when configuring the service, especially as Vite itself allows for configuration of the manifest file name (though not - annoyingly - it seems the manifest output path)
craft-plugin-vite/src/services/VitePluginService.php
Line 93 in fbf1bc5
manifest path has changed in Vite 5, so cannot simply use sourcePath to build path to the manifest.json
Maybe simply check if manifestPath is already set in service config then dont override it.
The text was updated successfully, but these errors were encountered: