Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-LD data not automatically rendering #101

Closed
richardcalahan opened this issue May 3, 2018 · 5 comments
Closed

JSON-LD data not automatically rendering #101

richardcalahan opened this issue May 3, 2018 · 5 comments
Assignees
Labels
need info Need more information on the issue

Comments

@richardcalahan
Copy link

richardcalahan commented May 3, 2018

I may be misunderstanding the plugin setting "Automatic Render Enabled", but if enabled, should all JSON-LD data be rendering automatically? Mine seems incomplete.

For example, under site settings, I've configured the following for location data under Identity:
screen shot 2018-05-03 at 10 55 24 am

But on the frontend, I see:
screen shot 2018-05-03 at 10 56 45 am

I'm running:
Craft 3.0.5
SEOMatic 3.0.10

@khalwat
Copy link
Collaborator

khalwat commented May 3, 2018

So it's automatically rendering the JSON-LD -- are you seeing any additional ld+json on the page? (you should)

@khalwat khalwat added the need info Need more information on the issue label May 3, 2018
@khalwat
Copy link
Collaborator

khalwat commented May 4, 2018

I take it back; this is a regression.

@khalwat khalwat self-assigned this May 4, 2018
@khalwat khalwat added bug and removed need info Need more information on the issue labels May 4, 2018
@khalwat
Copy link
Collaborator

khalwat commented May 4, 2018

So I think this might actually be due to something they changed in Craft 3.0.5: craftcms/cms#2831

@khalwat
Copy link
Collaborator

khalwat commented May 4, 2018

Fixed in 362efcc

@khalwat khalwat closed this as completed May 4, 2018
@richardcalahan
Copy link
Author

Ah, sorry I missed your questions. I thought I'd get pinged by Github. Thanks for the fix, all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need info Need more information on the issue
Projects
None yet
Development

No branches or pull requests

2 participants