Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Router 4 POC in starter kyts #283

Closed
delambo opened this issue Oct 27, 2016 · 3 comments
Closed

React Router 4 POC in starter kyts #283

delambo opened this issue Oct 27, 2016 · 3 comments

Comments

@delambo
Copy link
Member

delambo commented Oct 27, 2016

I'd like to see how RR4 feels in the starter kyts. A branch in the Universal would be nice.

@dting
Copy link
Contributor

dting commented Oct 28, 2016

Hi @delambo

I'm not very familiar with the new react router but I gave this a shot.

I ran into this issue when trying to access the location in the Miss component, remix-run/react-router#4035, but other than that it seems to be working as a universal app.

@jaredpalmer
Copy link

We are using rr4 isomorphically. It's great.

Should I make a new starter-kyt in a PR or just modify the current one? Please advise.

@delambo
Copy link
Member Author

delambo commented Mar 18, 2017

@dting @jaredpalmer - we're going to go ahead and do this now with #442. Thanks for your input.

@delambo delambo closed this as completed Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants