Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit script load locations, inline code #53

Open
afischer opened this issue Aug 11, 2019 · 1 comment
Open

Audit script load locations, inline code #53

afischer opened this issue Aug 11, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses

Comments

@afischer
Copy link
Member

afischer commented Aug 11, 2019 •
edited
Loading

As Isaac said in #51, we could likely move many (if not all) of our script tags out of the document <head>.

It looks like all the other Library scripts are in the head (and we just haven't audited this in a while). [...] I think it would be worthwhile for us to be consistent about where scripts are included. [...] What do you think about moving the other includes so they can all be together? My hunch is that this wouldn't break anything but would be curious to see what you find.

Originally posted by @isaacwhite in #51

Additionally, as seen in #283, our inline client-side code could probably use some cleanup as well.
@afischer afischer added good first issue Good for newcomers to the project that are familiar with the tech Library uses enhancement New feature or request labels Aug 11, 2019
@juliliza
Copy link

good issue

@afischer afischer changed the title Audit script load locations Audit script load locations, inline code Aug 11, 2021
@xvandish xvandish mentioned this issue Aug 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afischer @juliliza